Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collectibles - Icon of _tokenURI (metadata) does not change #2264

Closed
coin77 opened this issue Feb 19, 2021 · 3 comments · Fixed by MetaMask/core#454
Closed

Collectibles - Icon of _tokenURI (metadata) does not change #2264

coin77 opened this issue Feb 19, 2021 · 3 comments · Fixed by MetaMask/core#454
Assignees
@estebanmino
Labels
NFTs issues related to collectibles - ERC721, ERC1155 type-bug Something isn't working

Comments

@coin77
Copy link

coin77 commented Feb 19, 2021

I added a customised ERC721 collectible to my iOS Metamask wallet. The ERC721 contains a set of status which can change over time. After adding the collectible, the correct icon from the metadata (_tokenURI) shows up. However, once the _tokenURI changes, the icon under "Collectibles" in Metamask does not change.
@coin77 coin77 added the type-bug Something isn't working label Feb 19, 2021
@estebanmino estebanmino added the NFTs issues related to collectibles - ERC721, ERC1155 label Apr 26, 2021
@estebanmino
Copy link
Contributor

Thanks for reporting @coin77

@estebanmino
Copy link
Contributor

we should update the collectibles and not completely ignore if the image changed here https://github.com/MetaMask/controllers/blob/develop/src/assets/AssetsDetectionController.ts#L271

@estebanmino estebanmino mentioned this issue Apr 26, 2021
Closed
@estebanmino estebanmino self-assigned this Apr 27, 2021
estebanmino added a commit to MetaMask/core that referenced this issue Apr 27, 2021
@estebanmino
fixes MetaMask/metamask-mobile#2264
4a78fe7
@estebanmino estebanmino mentioned this issue Apr 27, 2021
Merged
@mobularay
Copy link
Contributor

Normally, the "needs-dev-reivew" label is applied at the PR level, but this PR is not showing up, so I am adding the label here to help with visibility

PR: MetaMask/core#454

@mobularay mobularay added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 29, 2021
estebanmino added a commit to MetaMask/core that referenced this issue May 20, 2021
@estebanmino
Collectibles updates (#454)
b8ba44c 
* openseainterface

* openseainterface

* types

* fixes MetaMask/metamask-mobile#2264

* collectiblesmetadata

* collectiblecontract

* compareCollectiblesMetadata

* compareCollectiblesMetadatatest

* ignoreassigns

* lintfix

* Revert "Add BaseControllerV2 support to ComposableController (#447)"

This reverts commit 5777094.

* ApiCollectibleLastSale

* address

* addmetadata

* fixtests

* Revert "Revert "Add BaseControllerV2 support to ComposableController (#447)""

This reverts commit c3ebf47.

* ignore
@mobularay mobularay removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 21, 2021
MajorLift pushed a commit to MetaMask/core that referenced this issue Oct 11, 2023
@estebanmino @MajorLift
Collectibles updates (#454)
19e90b0 
* openseainterface

* openseainterface

* types

* fixes MetaMask/metamask-mobile#2264

* collectiblesmetadata

* collectiblecontract

* compareCollectiblesMetadata

* compareCollectiblesMetadatatest

* ignoreassigns

* lintfix

* Revert "Add BaseControllerV2 support to ComposableController (#447)"

This reverts commit 5777094.

* ApiCollectibleLastSale

* address

* addmetadata

* fixtests

* Revert "Revert "Add BaseControllerV2 support to ComposableController (#447)""

This reverts commit c3ebf47.

* ignore
MajorLift pushed a commit to MetaMask/core that referenced this issue Oct 11, 2023
@estebanmino @MajorLift
Collectibles updates (#454)
29baa51 
* openseainterface

* openseainterface

* types

* fixes MetaMask/metamask-mobile#2264

* collectiblesmetadata

* collectiblecontract

* compareCollectiblesMetadata

* compareCollectiblesMetadatatest

* ignoreassigns

* lintfix

* Revert "Add BaseControllerV2 support to ComposableController (#447)"

This reverts commit 5777094.

* ApiCollectibleLastSale

* address

* addmetadata

* fixtests

* Revert "Revert "Add BaseControllerV2 support to ComposableController (#447)""

This reverts commit c3ebf47.

* ignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@estebanmino estebanmino

Labels
NFTs issues related to collectibles - ERC721, ERC1155 type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Collectibles updates MetaMask/core
3 participants
@estebanmino @coin77 @mobularay