Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain swaps-controller up to date with controllers in next release #2606

Closed
estebanmino opened this issue Apr 28, 2021 · 2 comments
Closed
Assignees
Labels
swaps MetaSwaps issues

Comments

@estebanmino
Copy link
Contributor

This PR is breaking how swaps-controller works since it changed the BaseController, we should update it when updating controllers otherwise it won't work.

@mobularay
Copy link
Contributor

Solutions discussed and agreed on Slack:

Mark is implementing the solution; tracking on Mobile board to ensure that once it's done, Mobile team knows about it.

@wachunei
Copy link
Member

This is resolved by MetaMask/core#458

@Gudahtt Gudahtt closed this as completed May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
swaps MetaSwaps issues
Projects
None yet
Development

No branches or pull requests

4 participants