Restore ComposableController compatibility between different BaseControllers #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
replace-instanceof-with-duck-typing
branch
from
c1364b4
to
b6e67d1
Compare
…rollers When adding support for BaseControllerV2 to the ComposableController in #447, we accidentally removed support for using two different versions of the BaseController in the same ComposableController. This is because we used the `instanceof` operator to check whether a controller was extended from BaseController. The `instanceof` check has been replaced by a check for the `subscribe` function. It seems unlikely that a BaseControllerV2 controller will ever have a `subscribe` function because the controller messenger will be used for all events.
Gudahtt
force-pushed
the
replace-instanceof-with-duck-typing
branch
from
b6e67d1
to
ca35de0
Compare
The BaseControllerV2 class now prevents the use of the `subscribe` property, ensuring the duck typing strategy used by the ComposableController to tell old and new controllers apart continues to work.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…rollers (#458) When adding support for BaseControllerV2 to the ComposableController in #447, we accidentally removed support for using two different versions of the BaseController in the same ComposableController. This is because we used the `instanceof` operator to check whether a controller was extended from BaseController. The `instanceof` check has been replaced by a check for the `subscribe` function. It seems unlikely that a BaseControllerV2 controller will ever have a `subscribe` function because the controller messenger will be used for all events. The BaseControllerV2 class now prevents the use of the `subscribe` property, ensuring the duck typing strategy used by the ComposableController to tell old and new controllers apart continues to work.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…rollers (#458) When adding support for BaseControllerV2 to the ComposableController in #447, we accidentally removed support for using two different versions of the BaseController in the same ComposableController. This is because we used the `instanceof` operator to check whether a controller was extended from BaseController. The `instanceof` check has been replaced by a check for the `subscribe` function. It seems unlikely that a BaseControllerV2 controller will ever have a `subscribe` function because the controller messenger will be used for all events. The BaseControllerV2 class now prevents the use of the `subscribe` property, ensuring the duck typing strategy used by the ComposableController to tell old and new controllers apart continues to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding support for BaseControllerV2 to the ComposableController in #447, we accidentally removed support for using two different versions of the BaseController in the same ComposableController. This is because we used the
instanceofoperator to check whether a controller was extended from BaseController.The
instanceofcheck has been replaced by a check for thesubscribefunction. It seems unlikely that a BaseControllerV2 controller will ever have asubscribefunction because the controller messenger will be used for all events.