Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth/Popup broken - opens external browser #2812

Open
tennox opened this issue Jun 16, 2021 · 2 comments
Open

OAuth/Popup broken - opens external browser #2812

tennox opened this issue Jun 16, 2021 · 2 comments
Labels
community Issues or PRs opened by the MM community ready-for-dev Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-platform type-bug Something isn't working type-pinned

Comments

@tennox
Copy link

tennox commented Jun 16, 2021

Describe the bug
Trying to implement OAuth flow, but MetaMask opens the URL in a different browser and thus there is no connection to send back the authorization code via e.g. window.postMessage

To Reproduce
I tried making a minimal sandbox example:
https://codesandbox.io/s/popup-test-jmbgp

  1. Open on PC to start sandbox
  2. open sandbox app URL (e.g. https://jmbgp.csb.app/) in Metamask android app
  3. See that MetaMask opens popup in extra browser outside of metamask app, and the postMessage calls fail

Expected behavior
On most other browsers this works and is often used for e.g. OAuth flows

Smartphone (please complete the following information):

  • Device: OnePlus 6T
  • OS: Android 10.3
  • App Version: v2.4.0

to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@tennox tennox added the type-bug Something isn't working label Jun 16, 2021
@gantunesr gantunesr added the community Issues or PRs opened by the MM community label Aug 17, 2021
@sethkfman sethkfman added the stale Issues that have not had activity in the last 90 days label Jun 9, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 7 days with no activity. If you feel this was closed in error please reopen and provide evidence on the current production app. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 17, 2023
@tennox
Copy link
Author

tennox commented Jun 17, 2023

This issue is still valid and reproducible via the link in the description

@sethkfman sethkfman reopened this Jun 21, 2023
@sethkfman sethkfman reopened this Jun 21, 2023
@sethkfman sethkfman added type-pinned and removed stale Issues that have not had activity in the last 90 days labels Jun 21, 2023
@gauthierpetetin gauthierpetetin added team-mobile-platform Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues or PRs opened by the MM community ready-for-dev Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-mobile-platform type-bug Something isn't working type-pinned
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

5 participants