Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changelog release automation #10172

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Jun 28, 2024

Description

This PR updates the release cut GH action. The action will now generate the changelog from a CSV file of changes between to commits/tag/branches.

The input for this action now takes in a tag from the previous release in-order to base the changes.

The CSV file generate now uses the tag on each PR to assign the work to team for verification.

Related issues

Fixes:

Manual testing steps

  1. Plug this branch into the GH action
  2. Confirm it generates a release branch and csv test file

Screenshots/Recordings

Before

Example output: #10052

After

Example output: #10242

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Jun 28, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.51%. Comparing base (ea14ef7) to head (4a2faf5).
Report is 3 commits behind head on main.

Current head 4a2faf5 differs from pull request most recent head b292665

Please upload reports for the commit b292665 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10172   +/-   ##
=======================================
  Coverage   49.50%   49.51%           
=======================================
  Files        1438     1438           
  Lines       34674    34676    +2     
  Branches     3853     3853           
=======================================
+ Hits        17166    17169    +3     
  Misses      16426    16426           
+ Partials     1082     1081    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethkfman sethkfman marked this pull request as ready for review June 28, 2024 22:16
@sethkfman sethkfman requested review from a team as code owners June 28, 2024 22:16
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first review pass, I still have the mjs file to check

.github/workflows/create-release-pr.yml Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
scripts/changelog-csv.sh Outdated Show resolved Hide resolved
scripts/changelog-csv.sh Show resolved Hide resolved
scripts/changelog-csv.sh Show resolved Hide resolved
scripts/create-release-pr.sh Outdated Show resolved Hide resolved
scripts/changelog-csv.sh Outdated Show resolved Hide resolved
scripts/changelog-csv.sh Outdated Show resolved Hide resolved
scripts/create-release-pr.sh Outdated Show resolved Hide resolved
scripts/create-release-pr.sh Outdated Show resolved Hide resolved
scripts/create-release-pr.sh Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
scripts/generate-rc-commits.mjs Outdated Show resolved Hide resolved
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Can you point me to a test PR created with this workflow?

@sethkfman sethkfman added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 3, 2024
@sethkfman
Copy link
Contributor Author

@NicolasMassart Here is an example PR. I know there are a few improvements by using GH refs and not string literals. Can we hold off on those updates? I would like to use this script on 7.27.0 RC cut.

NicolasMassart
NicolasMassart previously approved these changes Jul 5, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sethkfman
Copy link
Contributor Author

sethkfman commented Jul 5, 2024

@SocketSecurity ignore npm/simple-git@3.25.0

This is expected to help support the creation of a file.

NicolasMassart
NicolasMassart previously approved these changes Jul 5, 2024
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

sonarcloud bot commented Jul 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants