-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: changelog release automation #10172
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10172 +/- ##
=======================================
Coverage 49.50% 49.51%
=======================================
Files 1438 1438
Lines 34674 34676 +2
Branches 3853 3853
=======================================
+ Hits 17166 17169 +3
Misses 16426 16426
+ Partials 1082 1081 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first review pass, I still have the mjs file to check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Can you point me to a test PR created with this workflow?
@NicolasMassart Here is an example PR. I know there are a few improvements by using GH refs and not string literals. Can we hold off on those updates? I would like to use this script on 7.27.0 RC cut. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@SocketSecurity ignore npm/simple-git@3.25.0 This is expected to help support the creation of a file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Quality Gate passedIssues Measures |
Description
This PR updates the release cut GH action. The action will now generate the changelog from a CSV file of changes between to commits/tag/branches.
The input for this action now takes in a tag from the previous release in-order to base the changes.
The CSV file generate now uses the tag on each PR to assign the work to team for verification.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Example output: #10052
After
Example output: #10242
Pre-merge author checklist
Pre-merge reviewer checklist