feat: add utility function to get supported chains from the Security Alerts API #10267
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
|
There is usage of |
| ); | ||
| } | ||
|
|
||
| return response.json(); |
There was a problem hiding this comment.
Can we remove the duplication and create a request function for example that accepts the method and some extra properties?
| @@ -19,6 +21,10 @@ export async function validateWithSecurityAlertsAPI( | |||
| return postRequest(endpoint, request); | |||
| } | |||
|
|
|||
| export async function getSupportedChains(): Promise<Hex[]> { | |||
There was a problem hiding this comment.
Maybe getSecurityAlertsAPISupportedChainIds to be explicit?
| const supportedChains = isSecurityAlertsAPIEnabled() | ||
| ? await getSupportedChains() | ||
| : BLOCKAID_SUPPORTED_CHAIN_IDS; | ||
| return supportedChains.includes(chainId); |
There was a problem hiding this comment.
Minor, but could we remove some duplication with something like:
let supportedChainIds = BLOCKAID_SUPPORTED_CHAIN_IDS;
try {
if(isSecurityAlertsAPIEnabled()) {
supportedChainIds = getSupportedChainds();
}
} catch (e) {
Logger.log(
`Error fetching supported chains from security alerts API: ${e}`,
);
}
return supportedChainIds.includes(chainId);
| @@ -238,6 +238,9 @@ describe('PPOM Utils', () => { | |||
|
|
|||
| it('uses security alerts API if enabled', async () => { | |||
| isSecurityAlertsEnabledMock.mockReturnValue(true); | |||
| jest | |||
There was a problem hiding this comment.
Minor, but could we create a persistent variable for this such as getSupportedChainsMock like we do for isSecurityAlertsEnabledMock?
Description
This PR aims to include a new utility function to get supported chains from the Security Alerts API when enabled.
Related Repository
Refer to the Security Alerts API repository for more details.
Related issues
Fixes:
Manual testing steps
Test blockaid regression
add the envs
security-alertsand find the call to the API service.Existing PPOM logic should function as before, even with the above environment variables added, due to the fallback to the controller in the event of an error.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist