Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move SnapsExecutionWebView out of Main navigation stack #10268

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

Jonathansoufer
Copy link
Contributor

Description

This PR Fix a bug happening while app is locked. A state mismatch between the ExecutionService state and the actual WebView would cause snap calls to fail.

Related issues

Fixes:

Manual testing steps

  1. Go to Settings
  2. Enable Notifications if its disabled
  3. Lock the app.
  4. Try to enable/disable notifications again.

Screenshots/Recordings

Before

SnapBugBefore.mov

After

SnapBugAfter.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer self-assigned this Jul 9, 2024
@Jonathansoufer Jonathansoufer requested a review from a team as a code owner July 9, 2024 13:08
Copy link
Contributor

github-actions bot commented Jul 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Jonathansoufer Jonathansoufer added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9e097ec
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a269ac52-ef8a-48a7-8b5d-e90cbeb0f45a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Jul 10, 2024

@Jonathansoufer Jonathansoufer merged commit b87c1f8 into main Jul 10, 2024
32 checks passed
@Jonathansoufer Jonathansoufer deleted the fix/snap-webviewservice-bug branch July 10, 2024 14:47
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
@metamaskbot metamaskbot added the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.28.0 Issue or pull request that will be included in release 7.28.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-snaps-platform Snaps Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants