Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ramp): use hexToBN for ContractBalances balance #10271

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jul 9, 2024

Description

This PR fixes a missing line to convert to BN instance from this previous PR

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added team-ramp issues related to Ramp features team-mobile-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jul 9, 2024
@wachunei wachunei marked this pull request as ready for review July 9, 2024 19:29
@wachunei wachunei requested review from a team as code owners July 9, 2024 19:29
@tommasini tommasini added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 9, 2024
tommasini
tommasini previously approved these changes Jul 9, 2024
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If possible just see if the cast could be to Hex! Or better, type the return of this function as Hex at the utils folder

@wachunei wachunei requested a review from a team as a code owner July 9, 2024 20:06
Copy link

sonarcloud bot commented Jul 9, 2024

@wachunei wachunei merged commit 4fa9dc3 into main Jul 9, 2024
32 checks passed
@wachunei wachunei deleted the fix/ramp-use-balance-hook branch July 9, 2024 20:43
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2024
@metamaskbot metamaskbot added the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.28.0 Issue or pull request that will be included in release 7.28.0 team-mobile-platform team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants