-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add deep partial single source of truth #10272
Merged
Merged
+40
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce of truth for usage of deep partial
tommasini
added
No QA Needed
Apply this label when your PR does not need any QA effort.
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
team-mobile-platform
labels
Jul 9, 2024
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpcloureiro
suggested changes
Jul 10, 2024
Co-authored-by: João Loureiro <1649425+jpcloureiro@users.noreply.github.com>
@jpcloureiro Linter fixed <3 |
Approval once lint issues are resolved |
wachunei
approved these changes
Jul 10, 2024
jpcloureiro
approved these changes
Jul 10, 2024
Quality Gate passedIssues Measures |
github-actions
bot
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Jul 10, 2024
metamaskbot
added
the
release-7.28.0
Issue or pull request that will be included in release 7.28.0
label
Jul 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
No QA Needed
Apply this label when your PR does not need any QA effort.
release-7.28.0
Issue or pull request that will be included in release 7.28.0
team-mobile-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add deep partial for root state engine, and also create a single source of truth for usage of deep partial
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist