Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add deep partial single source of truth #10272

Merged
merged 7 commits into from
Jul 10, 2024

Conversation

tommasini
Copy link
Contributor

Description

Add deep partial for root state engine, and also create a single source of truth for usage of deep partial

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform labels Jul 9, 2024
@tommasini tommasini requested review from a team as code owners July 9, 2024 19:46
Copy link
Contributor

github-actions bot commented Jul 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

app/util/test/renderWithProvider.tsx Outdated Show resolved Hide resolved
tommasini and others added 2 commits July 10, 2024 12:01
Co-authored-by: João Loureiro <1649425+jpcloureiro@users.noreply.github.com>
@tommasini
Copy link
Contributor Author

@jpcloureiro Linter fixed <3

@jpcloureiro jpcloureiro self-requested a review July 10, 2024 11:30
@jpcloureiro
Copy link
Contributor

Approval once lint issues are resolved

Copy link

sonarcloud bot commented Jul 10, 2024

@tommasini tommasini merged commit 8574dc6 into main Jul 10, 2024
30 checks passed
@tommasini tommasini deleted the chore/deep-partial-for-root-state branch July 10, 2024 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 10, 2024
@metamaskbot metamaskbot added the release-7.28.0 Issue or pull request that will be included in release 7.28.0 label Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.28.0 Issue or pull request that will be included in release 7.28.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants