Added .ruby-version #1165
Merged
Added .ruby-version #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
suggested changes
Oct 22, 2019
There was a problem hiding this comment.
Hey @Zidail, thanks for your PR!
Regarding the .ruby-version addition, that's a good idea, but I'd prefer to use 2.3.7 which is what's installed by default in MacOS Mojave and it's what we use on CI.
Regarding moving the gemfile to the root, I don't think that's necessary cause we're not using ruby at all for android projects, so I'd prefer to keep it the way it is.
In the future, when you have ideas like this I recommend you to open a github issue first to start a discussion before doing any work so we're all in the same page.
|
@brunobar79 Thanks for the feedback. I'll be sure to do that in the future. |
brunobar79
pushed a commit
that referenced
this pull request
Nov 12, 2019
This reverts commit 4d640e9.
brunobar79
pushed a commit
that referenced
this pull request
Nov 12, 2019
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What Changed:
.ruby-versionand set project ruby version to 2.3.7Why create a separate file for saving the ruby version?
Just like how we specify which version of node we need to use with the
.nvmrc, we should also specify which version of ruby we should use.Adding this file allows us to tell
rbenvandrvmwhich version should be used for this project and minimize conflicts that may arise from different contributors using different versions of ruby.Checklist
Issue
Resolves None