Detox: Fix Android e2e Tests #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrahimtaveras00
changed the title
brunobar79
approved these changes
Nov 23, 2019
| @@ -594,7 +594,7 @@ export function getWalletNavbarOptions(title, navigation) { | |||
| return { | |||
| headerTitle: <NavbarTitle title={title} />, | |||
| headerLeft: ( | |||
| <TouchableOpacity onPress={openDrawer} style={styles.backButton}> | |||
| <TouchableOpacity onPress={openDrawer} style={styles.backButton} testID={'hamburger-menu-button-wallet'}> | |||
| @@ -348,7 +348,7 @@ export function getBrowserViewNavbarOptions(navigation) { | |||
|
|
|||
| return { | |||
| headerLeft: ( | |||
| <TouchableOpacity onPress={onPress} style={styles.backButton}> | |||
| <TouchableOpacity onPress={onPress} style={styles.backButton} testID={'hamburger-menu-button-browser'}> | |||
| <TouchableWithoutFeedback | ||
| style={styles.hamburger} | ||
| onPress={this.onNext} | ||
| testID={'hamburger-menu-button-wallet-fake-af'} |
e2e/dapp-initiated-txn.spec.js
Outdated
| const Correct_Seed_Words = 'fold media south add since false relax immense pause cloth just raven'; | ||
| const Correct_Password = `12345678`; | ||
| const CORRECT_SEED_WORDS = 'fold media south add since false relax immense pause cloth just raven'; | ||
| const CORRECT_PASSWORD = `12345678`; | ||
| const Ropsten = 'Ropsten Test Network'; |
There was a problem hiding this comment.
Since you fixed the other two, make all these const uppercase
e2e/helpers.js
Outdated
| .tap(); | ||
| } | ||
|
|
||
| static tapAtPoint(elementId, point) { | ||
| return element(by.id(elementId)).tapAtPoint(point); | ||
| } | ||
|
|
||
| static tapFirstItem(elementID, index) { |
There was a problem hiding this comment.
You should rename this function to tapItemAtIndex
e2e/helpers.js
Outdated
| } else { | ||
| await TestHelpers.tap(elementId); | ||
| } | ||
| // if (device.getPlatform() === 'android') { |
e2e/helpers.js
Outdated
| if (device.getPlatform() === 'android') { | ||
| return TestHelpers.typeText(elementId, text); | ||
| } | ||
| // if (device.getPlatform() === 'android') { |
e2e/helpers.js
Outdated
| } | ||
| await TestHelpers.typeText(elementId, text + '\n'); | ||
| // if (device.getPlatform() === 'android') { |
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* import wallet flow working * fix start exploring * making android great again * fixed wallet tests to work on android * fix warning on iOS sim that causes test to fail * made dapp-initiated-txn file work on droid * Android is great again * code review updates and added dapp contract deployment and approve tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes e2e tests to work on Android
Android now has 100% parity in test coverage compared to iOS
(Android on left... iOS on right)
I also added a test for the Dapp contract deployment & approve transactions (seen here = http://recordit.co/YCuLV8UjrZ) as an addition to the dapp-initiated-txn.spec.js file