UI Updates #155
Merged
UI Updates #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunobar79
commented
Nov 13, 2018
estebanmino
reviewed
Nov 13, 2018
estebanmino
reviewed
Nov 13, 2018
estebanmino
reviewed
Nov 13, 2018
estebanmino
reviewed
Nov 13, 2018
There was a problem hiding this comment.
new UI is awesome! QAed,
- We have the same issue that we had before in the
Import Walletview for android, it needs a scrollview to render all the view. - Transaction view doesn't render dropdowns in android. I can take a look at this because is not something added with this PR.
Didn't find anything else, looks good to me! Don't think previous code related comments are blockers, when we have new GABA release we should be able to merge this.
bitpshr
approved these changes
Nov 14, 2018
|
@estebanmino @bitpshr Thanks for reviewing such a big PR (Let's blame devcon!) Regarding the import wallet view, I've fixed the scrolling issue. |
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* good progress * more fixes * update splash screen * account and icons * update snapshots * send tx working * fix send tx * fix send tx * clean up * working * fix account scroll * fix account stuff * checksumAddress everywhere * filter txs by account * ipfs-ens fixes * added onScroll for browser * clean up * browser ui update * browser ui improvements * bump react-native-web3-webview * working * added individual browser screen * added network selector * update burger menu * fix * updates * update tests * fix bug when upddating url * more fixes * more fixes * fix browser navigation on android; * improve android menu * fix user agent stuff * bump react-native-web3-webview * bump node version * clean up * point to gaba branch * update unit tests * code review comments * support for custom RPC endpoints * forgot mainnet * fix android layout * add support for custom RPC * update app settings * bump gaba * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting the UI towards https://consensys.invisionapp.com/share/3TOQL9E27WS#/screens/327056897
Fixes #142 + Android crash when dismissing the webview.