Fix browser initial loading performance #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepimenta
added
the
needs-qa
ibrahimtaveras00
added
QA Passed
|
hi @andrepimenta, do we public InpageBridgeWeb3 file? I want to inject window.ethereum manually for my dapps browser personal |
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* Fix browser initial loading performance * Update test Co-authored-by: Ibrahim Taveras <ibrahimtaveras00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the browser initial load performance issue. The initial loading was being delayed mainly because:
InpageBridgeWeb3from the Filesystem which is very slow. The fix was creating a helper that gets theInpageBridgeWeb3on app init asynchronously so that when the user gets to the browser it is already loaded.This should make the time between the mounting of the browser component and the beginning of the loading be almost instantaneous.
Checklist
Issue
Resolves #1543