filter sentry tx rejected errors #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepimenta
approved these changes
May 22, 2020
There was a problem hiding this comment.
Just one comment, if we are going to have more of those "errors" ignored. Maybe use an array.
And then instead of if (error && error.message !== REJECTED_TRANSACTION_ERROR) we could do if (!ignoreErrors.find(ignore => error && ignore === error.message) ), something like this.
Otherwise, LGTM! 👍
|
Does this one need QA? I'd say it's good to merge and I can double check during regression testing |
ibrahimtaveras00
added
the
No QA Needed/E2E Only
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
Co-authored-by: Ibrahim Taveras <ibrahimtaveras00@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have many
User rejected the transactionerrors on sentry that don't give us any value because that's what happens when a user rejects a tx, is not an error nor a crash. So I added a filter to not send that to sentry.Checklist
Issue
Resolves #???