Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detox: Update to signature tests #1584

Merged
merged 1 commit into from
May 19, 2020
Merged

Conversation

ibrahimtaveras00
Copy link
Contributor

This PR adds an update to our sign tests since the button changed per last release.

Also, after adding settings to the drawer menu, the position of the log out button was lower which needed a swipe performed to be able to tap it. That is fixed too.

@ibrahimtaveras00 ibrahimtaveras00 added detox QA Passed A successful QA run through has been done labels May 16, 2020
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
we could also go adding ids on these buttons so you don't have to do this again if they change again

@ibrahimtaveras00 ibrahimtaveras00 merged commit fe04a9a into develop May 19, 2020
@ibrahimtaveras00 ibrahimtaveras00 deleted the detox/sign-tests-update branch May 19, 2020 22:53
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants