Feature/incoming token transactions #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
approved these changes
Jun 5, 2020
| const ticker = getTicker(args.ticker); | ||
| let transactionType; | ||
| if (renderFullAddress(from) === selectedAddress) transactionType = TRANSACTION_TYPES.SENT_TOKEN; | ||
| else transactionType = TRANSACTION_TYPES.RECEIVED_TOKEN; |
| let transactionType; | ||
| if (renderFrom === selectedAddress) transactionType = TRANSACTION_TYPES.SENT_COLLECTIBLE; | ||
| else transactionType = TRANSACTION_TYPES.RECEIVED_COLLECTIBLE; | ||
|
|
Co-authored-by: ricky <ricky.miller@gmail.com>
…Mask/metamask-mobile into feature/incoming-token-transactions
estebanmino
added
needs-dev-review
ibrahimtaveras00
suggested changes
Jul 9, 2020
There was a problem hiding this comment.
Issue 1:
The txn history updates roughly every 15 seconds or so = http://recordit.co/iH31hzRKLQ
If you are viewing txn details and have the modal open, this action will automatically close the modal = http://recordit.co/HnTwgPoYj1
Issue 2:
I wanted to test canceling a txn, but found that I can't send any ETH on Rinkeby or Ropsten, this was the error I got on Rinkeby
Followed by this:
Issue 3:
Padding is a bit off on the icon's on Android; seen here on a pixel 2 device
ibrahimtaveras00
added
QA'd - Issues Found
estebanmino
added
needs-qa
|
Issue 1 fixed with MetaMask/core@0db69d9 |
ibrahimtaveras00
suggested changes
Jul 15, 2020
There was a problem hiding this comment.
Issues 1 -3 have been resolved 👍
Issue 4:
Something weird with SAI is occurring where I sent SAI to an account, but it's appearing as received DAI; seen here = https://recordit.co/q5S2nZ0Hj5
ibrahimtaveras00
added
QA'd - Issues Found
estebanmino
added
needs-qa
ibrahimtaveras00
approved these changes
Jul 16, 2020
ibrahimtaveras00
added
QA Passed
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* wip * filter tx by token * tx icons * fix type * handle tx type * delete log * recived tx * recived tx * recived tx * Apply suggestions from code review Co-authored-by: ricky <ricky.miller@gmail.com> * pass alethio key and package * review suggestions * lint * lock packages * update package * stretch * snaps * controllers bump * lock * lock * sai Co-authored-by: ricky <ricky.miller@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://trello.com/c/GbmznAVK/104-view-received-tokens
Needed to work MetaMask/core#247
Checklist
Issue
Resolves #???