Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/wc connect on app closed #1625

Merged
merged 7 commits into from
Jun 12, 2020
Merged

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Jun 12, 2020

Description

This PR fixes the issue of opening a wallet connect connect request when the app was closed. What was happening was that the wc request was coming first than the app being initialized sometimes, so

  • I moved the initialization (specially the listener of that method) do be the first thing that the app does when is starting.
  • Added an initialized flag that defines when the Main component was mounted to process connect requests from wallet connect.

Because of these reasons I also removed a timeout that we had, we're handling it now.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner June 12, 2020 01:40
@estebanmino estebanmino changed the title fix: wc connect on app closed Bugfix/wc connect on app closed Jun 12, 2020
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good solution! 👍

@estebanmino estebanmino merged commit aa2895d into develop Jun 12, 2020
@estebanmino estebanmino deleted the fix/wc-connect-on-app-closed branch June 12, 2020 13:32
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* wait for mounted on entry

* init before evrything

* Revert "wait for mounted on entry"

This reverts commit 4acafcc.

* waitforinitialization

* changelog

* fix awaitforinit

* rm log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants