Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/deep link send token ui #1708

Merged
merged 5 commits into from
Jul 22, 2020
Merged

bugfix/deep link send token ui #1708

merged 5 commits into from
Jul 22, 2020

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Jul 21, 2020 •
edited
Loading

Description

Value of token transfer deeplinks and qr codes were displaying incorrect number
Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #1549

@estebanmino estebanmino requested a review from a team as a code owner July 21, 2020 21:24
@estebanmino estebanmino added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jul 21, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amount is shown correctly, QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jul 21, 2020
@estebanmino estebanmino merged commit d279f79 into develop Jul 22, 2020
@estebanmino estebanmino deleted the bugfix/qrcode-send-token branch July 22, 2020 18:05
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix/deep link send screen token ui (#1708)
1115a07 
* fix ui

* flex wrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERC-681 implementation bug: Wrong value on ERC-20 token transactions
3 participants
@estebanmino @andrepimenta @ibrahimtaveras00