Bugfix/allow mixed content #1867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
commented
Oct 1, 2020
| @@ -4,5 +4,5 @@ | |||
|
|
|||
| <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/> | |||
|
|
|||
| <application android:usesCleartextTraffic="true" tools:targetApi="28" tools:ignore="GoogleAppIndexingWarning" /> | |||
There was a problem hiding this comment.
It doesn't appear we actually need this here since we're setting it in <network-security-config> in react_native_config.xml
rickycodes
commented
Oct 1, 2020
rickycodes
force-pushed
the
bugfix/allow-mixed-content
branch
from
badc06d
to
41b4299
Compare
rickycodes
commented
Oct 2, 2020
| initializeFlipper(this, getReactNativeHost().getReactInstanceManager()); | ||
| RNBranchModule.getAutoInstance(this); | ||
| if (BuildConfig.DEBUG) { | ||
| WebView.setWebContentsDebuggingEnabled(true); |
There was a problem hiding this comment.
this is needed to debug the WebView for android
rickycodes
added
the
needs-dev-review
|
closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed recently that we don't allow for mixed content in the browser:
This is contrary to how browsers typically handle mixed content, for example on desktop the image loads fine for me (with a warning) in Firefox:
the following changes allow for mixed content in our webview so we can load http assets when a site is https:
Leaving this as a Draft to facilitate a discussion (also because this includes #1864).
There could be reasons why we might not want to do this, but we should ideally function like other browsers do? thoughts?
Checklist
Issue
Resolves #???