Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/whats new #1911

Merged
merged 6 commits into from
Nov 4, 2020
Merged

Feature/whats new #1911

merged 6 commits into from
Nov 4, 2020

Conversation

andrepimenta
Copy link
Member

@andrepimenta andrepimenta commented Oct 26, 2020

Description

This PR implements a dynamic way of showing new updates in-app on a "What's new" modal.
It's possible at any time to add new feature updates to a list with a few parameters in order to specifically show those updates to certain versions.

Simulator Screen Shot - iPhone 11 Pro iOS 13 3 - 2020-10-26 at 14 57 22

@ibrahimtaveras00 to test this we need to make sure that all users that have <1.0.5 and are updating to >=1.0.5 see it, so for example:
User installs version 1.0.4 and then updates to 1.0.5: Should see it
User fresh installs version 1.0.5: Should not see it
User installs version 1.0.5 and then updates to 1.0.6: Should not see it
User installs version 1.0.4 or less and then updates to 1.0.7: Should see it

To test several versions we need to manually change the version you want to install and then rebuild it:
On Xcode do
Screenshot 2020-10-26 at 14 54 57

And then do yarn start:ios again.

For android go to android/app/build.gradle
Screenshot 2020-10-26 at 14 55 43

And then do yarn start:android again.

@andrepimenta andrepimenta requested a review from a team as a code owner October 26, 2020 14:56
@andrepimenta andrepimenta added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 26, 2020
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All scenarios mentioned above passed 👍

Screen Shot 2020-10-30 at 6 50 37 PM

Correctly takes me to settings

QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 30, 2020
Copy link
Member

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	app/components/Nav/Main/index.js
@andrepimenta andrepimenta merged commit fac74f3 into develop Nov 4, 2020
@andrepimenta andrepimenta deleted the feature/whats-new branch November 4, 2020 21:54
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* whats new working

* Adjust to final design

* remove unnecessary logs

* fix typo

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) next release QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants