Fix activeTabUrl #2005
Merged
Fix activeTabUrl #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
added
needs-dev-review
rickycodes
commented
Nov 19, 2020
| @@ -549,6 +555,7 @@ class ApproveTransactionReview extends PureComponent { | |||
| primaryCurrency, | |||
| currentCurrency, | |||
| gasError, | |||
| activeTabUrl, | |||
There was a problem hiding this comment.
we were still trying to get it from component state instead of props
rickycodes
commented
Nov 19, 2020
| @@ -10,7 +10,7 @@ exports[`ApproveTransactionModal should render correctly 1`] = ` | |||
| } | |||
| } | |||
| accountsLength={1} | |||
| activeTabUrl="" | |||
| activeTabUrl="https://metamask.github.io/test-dapp/" | |||
rickycodes
commented
Nov 19, 2020
| @@ -143,7 +143,7 @@ const TransactionHeader = props => { | |||
| let title = ''; | |||
| if (originIsDeeplink) title = renderShortAddress(spenderAddress); | |||
| else if (originIsWalletConnect) title = getHost(origin.split(WALLET_CONNECT_ORIGIN)[1]); | |||
| else title = getHost(currentEnsName || url); | |||
| else title = getHost(currentEnsName || url || origin); | |||
There was a problem hiding this comment.
here we fall back to origin, but it's not really necessary (better than potentially showing undefined if this ever breaks again)
estebanmino
approved these changes
Nov 19, 2020
ibrahimtaveras00
added
QA in Progress
rickycodes
removed
the
needs-dev-review
ibrahimtaveras00
added
QA Passed
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
* Fix transaction header title * Get activeTabUrl from props now * Update tests * Update CHANGELOG * bump * fixwcicon Co-authored-by: Esteban Mino <efmino@uc.cl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now there's an issue in the
TransactionHeadercomponent where theurlprop that's being passed isundefined:This fixes that:
There might be a better fix? Maybe this component could use a refactor where it no longer requires asurlprop? For now I think this is a good defensive patch.Checklist
Issue
Resolves #???