Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alert from iframes #2143

Merged
merged 1 commit into from Jan 20, 2021
Merged

Fix alert from iframes #2143

merged 1 commit into from Jan 20, 2021

Conversation

andrepimenta
Copy link
Member

Description

Fix alert from iframes

Issue

Resolves #2138

@andrepimenta andrepimenta requested a review from a team as a code owner January 20, 2021 15:13
estebanmino
estebanmino approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrepimenta andrepimenta merged commit 431eb9d into develop Jan 20, 2021
@andrepimenta andrepimenta deleted the fix/webview-iframe-alert-fix branch January 20, 2021 18:38
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@andrepimenta
Fix alert from iframes (#2143)
fbf0117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

Assignees
No one assigned
Labels
next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v1.0.9 Regression Bug | App crashes when attempting to load site
2 participants
@andrepimenta @estebanmino