improvement/handle provider updates #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
commented
Feb 2, 2021
app/core/Engine.js
Outdated
| /** | ||
| * Refreshes all controllers that depend on the network | ||
| */ | ||
| refreshNetwork = () => { |
There was a problem hiding this comment.
this was here because the refresh was called many times ... now configureControllersOnNetworkChange is called once when the chainId changes
ibrahimtaveras00
added
the
needs-qa
andrepimenta
approved these changes
Feb 16, 2021
ibrahimtaveras00
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
This PR fixes the original issue
In regards to #2113 only Uniswap is working with this fix now, but I still have to reload for metamask.github.io/test-dapp
switching to Uniswap = https://recordit.co/h212ROp6Yf
switching on test-dapp = https://recordit.co/q4SIm97aVp
Nonetheless, passing since original issue is fixed 👍🏽
ibrahimtaveras00
added
QA Passed
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* fix * chinid * engine * removerefresh * test * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some issues were present when switching networks
getBalancecalls per 500 ms (about 7)Checklist
Issue
Resolves #2186