Fix circleci apk #2240
Merged
Fix circleci apk #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
reviewed
Feb 12, 2021
.circleci/config.yml
Outdated
| @@ -196,12 +197,14 @@ workflows: | |||
| only: | |||
| - master | |||
| - develop | |||
| - fix-circleci-apk | |||
There was a problem hiding this comment.
was this just for testing? are we planning on removing this before merge?
This reverts commit 60df2aa.
rickycodes
approved these changes
Feb 12, 2021
estebanmino
added a commit
that referenced
this pull request
Feb 16, 2021
* Remove best deals badge from WYRE transfers. (#2228) Co-authored-by: Shivam Chaturvedi <corsairshivam@gmail.com> * Handle `balanceError` case (#2148) * Handle `balanceError` case * Adjust error case * Update handling balanceError * Remove etherscan link * Add metamask-controllers from disk * Add translation strings * Remove etherscanUrl * Revert "Add metamask-controllers from disk" This reverts commit 75ac0c68b99e5bf2ff190c20cccad4df74a8806f. * Only use this style for error case * contract metadata images bump (#2233) * contractmetadata * snaps * remotesvg * Feature/warn when replacing (#2176) * mock login changes * mock warning modal * mock delete modal * mock delete warning and submitDelete * Add isTextDelete * Add autoFocus * clean up * "delete" * undo design changes * Add en translations * Update unit tests * fix * Make this async await and catch and log failure * Remove 12-word * Adjust lineHeight * fix typo * Add logic to show delete notification * Hide back button * Disable hardware back button press * Add notification * Add closeButtonDisabled functionality * Update styles * Hide back button better on Congratulations screen * Update translation * Add breakpoint for small devices * add missing "a" * fix warning modal * Clean up BaseNotification component * Remove added styles * Remove eslint-disable-next-line * Use InteractionManager * Remove empty onHide * update empty callback * Cleanup * Add flexDirection: 'row' * Move styles to WarningExistingUserModal * Dismiss keyboard * Add strings to locales * Simplify * Add loading screen for delete * Actually delete wallet * Fix modal tap area Co-authored-by: ricky <ricky@macbook.lan> * v1.0.11 (#2238) * version * bump * Update CHANGELOG.md * update * Update CHANGELOG * Remove disclosure PR * Fix circleci apk (#2240) * resouceclass * revert * Revert "revert" This reverts commit 60df2aa. * changelog * gaba * swaps-tx * MM_FOX_CODE * swaptxs * works * fix * TransactionController from controllers (#2243) * TransactionController from controllers * query * changelog * tests * 577 * 577 * details * transactionType * token * byaction * allworking * ceanup * locales * utils * check * edgecase * test * tests * approvals * filter * more Co-authored-by: Pedro Pablo Aste Kompen <wachunei@gmail.com> Co-authored-by: Shivam Chaturvedi <corsairshivam@gmail.com> Co-authored-by: ricky <ricky.miller@gmail.com> Co-authored-by: ricky <ricky@macbook.lan>
rickycodes
added a commit
that referenced
this pull request
Feb 25, 2021
* develop: (48 commits) Fix input state (#2265) bump android versionCode (#2260) bugfix/use bignumber for transfer deeplinks (#2257) Fix account list scroll (#2256) TransactionController from controllers (#2243) Fix circleci apk (#2240) v1.0.11 (#2238) Feature/warn when replacing (#2176) contract metadata images bump (#2233) Handle `balanceError` case (#2148) Remove best deals badge from WYRE transfers. (#2228) @metamask/controllers@6.0.1 (#2217) Fix cloudflare redirects (#2180) Merge pull request from GHSA-wmvx-96jh-gcr4 Update @metamask/contract-metadata (#2203) React Native update to 0.63 (#2078) Create dependabot.yml (#2204) Fix "Text strings must be rendered within a <Text> component" (#2193) Use navigate instead of push (#2191) Add fiat on ramp modal close button extra hit area (#2174) ...
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* resouceclass * revert * Revert "revert" This reverts commit 60df2aa. * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a short description of the changes included in this pull request.
Checklist
Issue
Resolves #???