Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style updates #2375

Merged
merged 11 commits into from
Apr 15, 2021
Merged

Style updates #2375

merged 11 commits into from
Apr 15, 2021

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented Mar 11, 2021 •
edited
Loading

re-opening this sine I merged #2201 too early my bad.

Description

Some design inconsistencies Christian brought up being addressed in this PR

This PR actually makes a lot of style updates so I will go through them:

  1. The baseStyles.black has been updated to not be absolute black.

  2. Type face updated in asset list for adding Tokens:

Before: After:
image image
  1. Type face updated in BaseNotification component:
Before: After:
image image
  1. Create password
Before: After:
image image
  1. Import from Seed
Before: After:
image image
  1. Login
Before: After:
image image

@rickycodes rickycodes requested a review from a team as a code owner March 11, 2021 22:24
@rickycodes rickycodes added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 11, 2021
estebanmino
estebanmino approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was already approved the last time 😅

@rickycodes rickycodes removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 8, 2021
@rickycodes
Copy link
Member Author

this was already approved the last time

I know 😭

needed re-approval because of the revert

@ibrahimtaveras00 ibrahimtaveras00 added next release QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 12, 2021
ibrahimtaveras00
ibrahimtaveras00 suggested changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one place looked off to me in terms of UX

The "Create a new wallet" flow on Wallet setup, the green arrow indicating the passwords match is misaligned

image

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed QA in Progress QA has started on the feature. labels Apr 15, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now

image

QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Apr 15, 2021
@rickycodes rickycodes merged commit fd19a47 into develop Apr 15, 2021
@rickycodes rickycodes deleted the style-updates branch April 15, 2021 21:11
@rickycodes rickycodes mentioned this pull request Apr 29, 2021
Merged
3 tasks
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Style updates (#2375)
6ba4014 
* Fix AssetList typeface

* Update BaseNotification text

* Update ChoosePassword ImportFromSeed

* Update styles

* Update snapshots

* Update snapshot

* fix checkmark position

* update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rickycodes @estebanmino @ibrahimtaveras00