Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check infura availability #2520

Merged
merged 25 commits into from Apr 14, 2021
Merged

Check infura availability #2520

merged 25 commits into from Apr 14, 2021

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Apr 13, 2021

Description

Waiting for

  • Designs confirmation
  • An eventual Infura endpoint

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves https://github.com/MetaMask/mobile-planning/issues/86

@estebanmino estebanmino requested a review from a team as a code owner April 13, 2021 18:29
@estebanmino estebanmino changed the title Check provider status [WIP] Check provider status Apr 13, 2021
Copy link
Member

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned in the chat I don't think we need ios/Podfile.lock changes

and i think snapshots need to be updated, but otherwise LGTM

@ibrahimtaveras00
Copy link
Contributor

I'm seeing this work for iOS but not for Android

Screen Shot 2021-04-13 at 7 17 33 PM

Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried on a real device and turned the WIFI off and it worked fine

👍🏽

Screen Shot 2021-04-13 at 7 25 05 PM

@ibrahimtaveras00 ibrahimtaveras00 added the QA Passed A successful QA run through has been done label Apr 14, 2021
@estebanmino estebanmino changed the title [WIP] Check provider status Check provider status Apr 14, 2021
@estebanmino
Copy link
Contributor Author

We're good to go

@estebanmino estebanmino changed the title Check provider status Check infura availability Apr 14, 2021
await util.query(TransactionController.ethQuery, 'blockNumber', []);
props.setInfuraAvailabilityNotBlocked();
} catch (e) {
if (e?.message === AppConstants.ERRORS.INFURA_BLOCKED_MESSAGE) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need ? here. .message will evaluate to undefined if it's not set in this case since it's top level.

@estebanmino estebanmino merged commit 8a91289 into develop Apr 14, 2021
@estebanmino estebanmino deleted the check-infura-alert branch April 14, 2021 20:12
estebanmino added a commit that referenced this pull request Apr 14, 2021
* addcheck

* component

* componentUI

* checkProviderStatus

* log

* finalstyle

* locales

* tryagain

* snapshots

* checkInfuraAvailability

* updatecopy

* handleinfura

* tests

* CONNECTIVITY_ISSUESlink

* copy

* copy

* translations

* e

* check

* test
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* addcheck

* component

* componentUI

* checkProviderStatus

* log

* finalstyle

* locales

* tryagain

* snapshots

* checkInfuraAvailability

* updatecopy

* handleinfura

* tests

* CONNECTIVITY_ISSUESlink

* copy

* copy

* translations

* e

* check

* test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants