Parse transaction data correctly #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
cortisiko
added
the
Sev1-high
cortisiko
requested changes
Sep 15, 2021
There was a problem hiding this comment.
@andrepimenta the transaction data still appears scrambled. See here
To reproduce:
Connect to this dappp: https://sorbet-finance-git-fix-metamask-mobile-bug-2-gelato.vercel.app/ (I used ropsten as my network)
Attempt to transfer some eth
Notice the transaction data appears wonky.
cortisiko
added
the
QA'd - Issues Found
|
@cortisiko Can you check against extension, if it's the same then it should be correct:
|
cortisiko
added
QA in Progress
cortisiko
added
QA Passed
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
Co-authored-by: andrepimenta <andrepimenta7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the way we parse transaction data.
@ibrahimtaveras00
How to test:
Test token transfers (ERC20 and ERC721) requested from a Dapp. Would be nice to check the etherscan parameters against the same transaction made by the extension, especially:
Before:
After:
Checklist
Issue
Resolves #2744
Resolves #3051