Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client id to GasFeeController #3181

Merged
merged 7 commits into from
Feb 4, 2022
Merged

Add client id to GasFeeController #3181

merged 7 commits into from
Feb 4, 2022

Conversation

meppsilon
Copy link
Contributor

Description

Add client id to GasFeeController so mobile could send the client id in the request headers to the gas api.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@meppsilon meppsilon requested a review from a team as a code owner September 27, 2021 17:28
wachunei
wachunei approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2021 •
edited

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added the community Issues or PRs opened by the MM community label Dec 2, 2021
@gantunesr
Copy link
Member

Hey @meppsilon, we need you to sign the CLA to unblock the PR. You can see the details about this is the previous comment

@meppsilon
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@gantunesr gantunesr added Code Impact - Low Minor code change that can safely applied to the codebase No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels Jan 13, 2022
@andrepimenta andrepimenta changed the base branch from develop to main February 4, 2022 17:48
@andrepimenta andrepimenta added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Feb 4, 2022
@andrepimenta andrepimenta merged commit c870854 into MetaMask:main Feb 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2022
@gantunesr gantunesr removed No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. community Issues or PRs opened by the MM community labels Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wachunei wachunei wachunei approved these changes

Assignees
No one assigned
Labels
Code Impact - Low Minor code change that can safely applied to the codebase Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@meppsilon @gantunesr @wachunei @andrepimenta @sethkfman @rickycodes