Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] ERC-1155 Support #3301

Merged
merged 44 commits into from
Oct 29, 2021
Merged

[FEAT] ERC-1155 Support #3301

merged 44 commits into from
Oct 29, 2021

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Oct 18, 2021

Description

Currently we don't support the collectible standard ERC-1155, the focus of this development is to integrated the ERC-1155 ABI to access the appropriate methods of the smart contract.

To Do

  • Update CollectiblesController
  • Add support to manually add ERC-1155 collectibles
  • Update tests

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 18, 2021
@gantunesr gantunesr requested a review from a team October 18, 2021 13:13
@gantunesr gantunesr changed the title [Feat] ERC-1155 Support [FEAT] ERC-1155 Support Oct 18, 2021
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments and questions.

app/components/UI/AddCustomCollectible/index.tsx Outdated Show resolved Hide resolved
app/util/analyticsV2.js Outdated Show resolved Hide resolved
package.json Outdated
@@ -87,7 +87,7 @@
"dependencies": {
"@exodus/react-native-payments": "https://github.com/wachunei/react-native-payments.git#package-json-hack",
"@metamask/contract-metadata": "^1.30.0",
"@metamask/controllers": "^17.0.0",
"@metamask/controllers": "./metamask-controllers-v17.0.0-erc-1155-v2.tgz",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update path once controller is released

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the controllers dependency and it looks good.

app/util/analyticsV2.js Outdated Show resolved Hide resolved
@gantunesr gantunesr mentioned this pull request Oct 27, 2021
4 tasks
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 27, 2021
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Oct 28, 2021
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮 🌮 🌮

@gantunesr gantunesr merged commit 7ce19f8 into develop Oct 29, 2021
@gantunesr gantunesr deleted the feat/erc1155 branch October 29, 2021 19:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2021
@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants