Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Mobile Vault Decryptor Functionality #3346

Merged
merged 12 commits into from
Nov 16, 2021
Merged

[FEATURE] Mobile Vault Decryptor Functionality #3346

merged 12 commits into from
Nov 16, 2021

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Oct 27, 2021 •
edited
Loading

Description

Allows a user who has exported a vault from an iOS/Android device to be used to import a seed phrase and setup a wallet. This requires the vault and the users password when the vault was created.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman changed the title Test/vault decryptor Mobile Vault Decryptor Functionality Oct 27, 2021
@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 28, 2021
@sethkfman sethkfman marked this pull request as ready for review October 28, 2021 16:41
@sethkfman sethkfman requested a review from a team as a code owner October 28, 2021 16:41
Cal-L
Cal-L approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after update

app/components/Views/ImportFromSeed/index.js Outdated Show resolved Hide resolved
@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 1, 2021
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 3, 2021
cortisiko
cortisiko approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 🔥 🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Nov 4, 2021
@sethkfman sethkfman changed the title Mobile Vault Decryptor Functionality [FEATURE] Mobile Vault Decryptor Functionality Nov 16, 2021
@sethkfman sethkfman removed the QA Passed A successful QA run through has been done label Nov 16, 2021
@Cal-L Cal-L added needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Nov 16, 2021
@sethkfman sethkfman merged commit f3d1787 into develop Nov 16, 2021
@sethkfman sethkfman deleted the test/vaultDecryptor branch November 16, 2021 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sethkfman @Cal-L @cortisiko