Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment/upgrade react native 66 #3509

Merged
merged 76 commits into from
Jan 20, 2022
Merged

Experiment/upgrade react native 66 #3509

merged 76 commits into from
Jan 20, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Dec 14, 2021

Description

#3425

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

Cal-L and others added 22 commits November 12, 2021 12:23
@Cal-L
Commit upgrade paths
29fc77e
@Cal-L
Checkpoint: iOS can build
7941f69
@Cal-L
Reintroduce viewpager library with patch (deprecated)
6fe9012
@Cal-L
Upgrade keyboard aware library to support new RN
54699fe
@Cal-L
Stabilize Android (WIP) need to patch react-native
eab0893
@Cal-L
Remove setting NDK. Android auto sets it based on gradle
4dcd14e
@Cal-L
Update build gradle + Add postinstall for react-native-codegen
1e82268
@Cal-L
Add comment for postinstall (react-native-codegen)
eafde4f
@Cal-L
Remove workspace settings
be13696
@Cal-L
Upgrade gradle versions. Fix viewpager patch. Revert to support pre-u…
57820f0 
…pgrade min sdk versions
@Cal-L
Merge branch 'experiment/upgrade-react-native-66' of https://github.c…
55034cc 
…om/MetaMask/metamask-mobile into experiment/upgrade-react-native-66
@Cal-L
Merge in from develop
3e54bba
@Cal-L
Fix unit tests
2604abf
@rickycodes
update rn codegen postinstall script
f64f649
@Cal-L
Merge branch 'develop' of https://github.com/MetaMask/metamask-mobile …
4b568cd 
…into experiment/upgrade-react-native-66
@Cal-L
Fix react-native-scrollable-tab-view with patch
acd3a89
@Cal-L
Update README.md ndk section
77b8342
@rickycodes
update rn codegen postinstall script
89d6d0c
@rickycodes
Merge branch 'experiment/upgrade-react-native-66' of github.com:MetaM…
97aa05d 
…ask/metamask-mobile into experiment/upgrade-react-native-66

* 'experiment/upgrade-react-native-66' of github.com:MetaMask/metamask-mobile:
  Update README.md ndk section
  Fix react-native-scrollable-tab-view with patch
  Postinstall as yarn setup (#3427)
@Cal-L
Merge in from develop
51822f0
@Cal-L
Merge from develop
337c176
@Cal-L
Update pod file lock
c12d72c
@Cal-L Cal-L requested a review from a team as a code owner December 14, 2021 21:25
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L force-pushed the experiment/upgrade-react-native-66 branch from 9a7161d to 81122bf Compare December 16, 2021 21:04
Cal-L and others added 21 commits January 9, 2022 17:29
@Cal-L
Re run unit tests
5e2fd11
@Cal-L
Update readme with Flipper instructions
62b8a04
@Cal-L
Remove requestAnimationFramea and InteractionManager that causes iOS …
22fbf99 
…to crash when switching networks
@Cal-L
Update EasingNode
8081e45
@Cal-L
Hide tab bar
61f066b
@Cal-L
Fix browser deep link
86deedb
@Cal-L
Upgrade web3 in controllers to fix app hang up.
e9ce251
@Cal-L
Remove isZero undefined from controllers
17f0974
@Cal-L
Handle initial and subsequent deeplinks to browser
12c9249
@Cal-L
Fix svg length undefined issue
a59d1f2
@Cal-L
Update build number
0bddb37
@Cal-L
Fix BN function calls + patch swaps controller
bc3f7f7
@Cal-L
Update build number
c3e907b
@Cal-L
Disable Hermes for iOS.
eb24429
@Cal-L
Disable hermes for Android
176abd7
@Cal-L
Update build number
614e1c1
@Cal-L
unset PREFIX on all bitrise steps
6bacd4e
@cortisiko
dimissing keyboard in wallet spec
a6608bf
@cortisiko
addressbook,wallet,request payment fix.
a5d9fd8
@rickycodes
update snapshots
050820e
@Cal-L
Remove intl polyfill
219fe9b
@Cal-L Cal-L added the Priority - High Task with high priority label Jan 18, 2022
cortisiko
cortisiko approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jan 18, 2022
gantunesr
gantunesr approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reviewed with @Cal-L 🚀

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 19, 2022
@Cal-L Cal-L merged commit 1f03de0 into develop Jan 20, 2022
@Cal-L Cal-L deleted the experiment/upgrade-react-native-66 branch January 20, 2022 17:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
Priority - High Task with high priority QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Cal-L @cortisiko @gantunesr @rickycodes