[FIX] Fixes renderFromGwei related crashes #3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
rickycodes
reviewed
Jan 5, 2022
app/components/UI/Notification/TransactionNotification/index.js
Outdated
Show resolved
Hide resolved
rickycodes
reviewed
Jan 5, 2022
rickycodes
approved these changes
Jan 5, 2022
gantunesr
added
the
needs-qa
|
@andreahaku can you provide steps to reproduce the bug for QA? Please |
This can be replicated by doing and ETH transaction from one account to another (same wallet or different wallet) and by tapping on any of the popup notification messages confirming the transaction on both the sending and/or receiving wallets/accounts. |
andreahaku
added
the
Code Impact - Medium
cortisiko
added
QA in Progress
cortisiko
added
QA Passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some crashes related to transaction notification info display and others related to calculating/displaying gas fees. The main issue was that calculated gwei where not always integers/string format but could be undefined/decimal crashing the numberToBN method.
Checklist
Issue
Resolves #3537