Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fixes text field frame got cut off #3548

Merged
merged 12 commits into from
Feb 15, 2022
Merged

[FIX] Fixes text field frame got cut off #3548

merged 12 commits into from
Feb 15, 2022

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Jan 8, 2022 •
edited

Description

On two different screens, the text field frame cuts off the bottom part of the text. This PR fixes both bugs.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3542

@blackdevelopa blackdevelopa requested a review from a team as a code owner January 8, 2022 04:06
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2022 •
edited

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa self-assigned this Jan 8, 2022
@blackdevelopa
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@blackdevelopa blackdevelopa added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 10, 2022
@gantunesr gantunesr added the Code Impact - Low Minor code change that can safely applied to the codebase label Jan 10, 2022
gantunesr
gantunesr reviewed Jan 10, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@Cal-L Cal-L mentioned this pull request Jan 27, 2022
Closed
3 tasks
Cal-L
Cal-L requested changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment and made a PR for suggested changes:
#3652

app/components/Views/BrowserTab/index.js Outdated Show resolved Hide resolved
@blackdevelopa blackdevelopa changed the base branch from develop to main February 3, 2022 21:30
@andrepimenta andrepimenta added No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. No QA Needed/E2E Only Apply this label when your PR does not need any QA effort. labels Feb 4, 2022
Cal-L
Cal-L approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 11, 2022
@gantunesr gantunesr merged commit d625602 into main Feb 15, 2022
@gantunesr gantunesr deleted the bugfix/textCutOff branch February 15, 2022 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr left review comments

@Cal-L Cal-L Cal-L approved these changes

Assignees

@blackdevelopa blackdevelopa

@plasmacorral plasmacorral

Labels
Code Impact - Low Minor code change that can safely applied to the codebase Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text field frame got cut off
5 participants
@blackdevelopa @Cal-L @gantunesr @andrepimenta @plasmacorral