Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fixes touch area of a close button and aligned the button #3558

Merged
merged 7 commits into from
Feb 4, 2022
Merged

[FIX] Fixes touch area of a close button and aligned the button #3558

merged 7 commits into from
Feb 4, 2022

Conversation

blackdevelopa
Copy link
Contributor

@blackdevelopa blackdevelopa commented Jan 11, 2022 •
edited

Description

When requesting payment with QR Code, the touch area of the close button is too small and not aligned. This PR fixes both

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3557

@blackdevelopa blackdevelopa requested a review from a team as a code owner January 11, 2022 06:16
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa self-assigned this Jan 11, 2022
@blackdevelopa blackdevelopa added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. Code Impact - Low Minor code change that can safely applied to the codebase labels Jan 11, 2022
andreahaku
andreahaku reviewed Jan 11, 2022
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's no need to include yarn.lock and Podfile.lock in the PR. It'd be better to commit only files related to the task. They can be included if you update/add/remove a dependency.

app/components/UI/PaymentRequestSuccess/index.js Outdated Show resolved Hide resolved
@blackdevelopa
Copy link
Contributor Author

I think there's no need to include yarn.lock and Podfile.lock in the PR. It'd be better to commit only files related to the task. They can be included if you update/add/remove a dependency.

Thank you. Updated.

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 14, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 26, 2022
cortisiko
cortisiko approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jan 26, 2022
@blackdevelopa blackdevelopa changed the base branch from develop to main February 4, 2022 13:52
@andrepimenta andrepimenta merged commit 92f7601 into main Feb 4, 2022
@andrepimenta andrepimenta deleted the fix/3557-close-button branch February 4, 2022 20:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr left review comments

@andreahaku andreahaku andreahaku approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees

@blackdevelopa blackdevelopa

Labels
Code Impact - Low Minor code change that can safely applied to the codebase QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Touch area of the close button is too small and button is not aligned
5 participants
@blackdevelopa @andreahaku @cortisiko @gantunesr @andrepimenta