Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line height is distributed unevenly when lineHeight <= fontSize #3593

Merged
merged 7 commits into from
Feb 7, 2022
Merged

Line height is distributed unevenly when lineHeight <= fontSize #3593

merged 7 commits into from
Feb 7, 2022
+11 −3

Conversation

nuoyz
Copy link
Contributor

@nuoyz nuoyz commented Jan 18, 2022

Description

When lineHeight is less than the fontSize, Text shrinks the line's bounding box only by removing space from above the text, rather than distributing the space evenly above and below, as is done with extra line height.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???
image
image

@nuoyz nuoyz requested a review from a team as a code owner January 18, 2022 12:58
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@nuoyz
Copy link
Contributor Author

nuoyz commented Jan 18, 2022

@rickycodes done

gantunesr
gantunesr reviewed Jan 18, 2022
View reviewed changes
ios/Podfile.lock Outdated Show resolved Hide resolved
gantunesr
gantunesr reviewed Jan 18, 2022
View reviewed changes
ios/Podfile.lock Outdated Show resolved Hide resolved
gantunesr
gantunesr requested changes Jan 18, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But remove the Podfile changes

@nuoyz nuoyz requested a review from gantunesr January 18, 2022 14:15
gantunesr
gantunesr reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nuoyz, looks like the tests are failing, can you ran this command to update the snapshots?

yarn test:unit:update

@nuoyz
Copy link
Contributor Author

nuoyz commented Jan 19, 2022

Hey @nuoyz, looks like the tests are failing, can you ran this command to update the snapshots?

yarn test:unit:update

image

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Jan 20, 2022
@gantunesr gantunesr mentioned this pull request Jan 21, 2022
Closed
@andrepimenta andrepimenta changed the base branch from develop to main February 4, 2022 18:51
@gantunesr gantunesr merged commit 607d906 into MetaMask:main Feb 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2022
@gantunesr gantunesr added community Issues or PRs opened by the MM community and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
community Issues or PRs opened by the MM community Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nuoyz @gantunesr