Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow BSC, Polygon, Avalanche native and stable coins for on-ramp #3607

Merged
merged 16 commits into from
Feb 8, 2022
Merged

Allow BSC, Polygon, Avalanche native and stable coins for on-ramp #3607

merged 16 commits into from
Feb 8, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Jan 20, 2022 •
edited

Description

This PR allows buying AVAX in Avalanche and supported stablecoins in all networks (USDT, USDC, DAI, BUSD)

⚠️ This PR includes changes from #3539 ℹ️ This PR superseeds #3539

@wachunei wachunei marked this pull request as ready for review January 24, 2022 18:05
@wachunei wachunei requested a review from a team as a code owner January 24, 2022 18:05
@wachunei wachunei mentioned this pull request Jan 25, 2022
Closed
@wachunei wachunei changed the title Allow Avalanche and stable coins for on-ramp Allow BSC, Polygon, Avalanche native and stable coins for on-ramp Jan 25, 2022
@wachunei wachunei changed the base branch from develop to main January 26, 2022 18:27
@wachunei wachunei added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 27, 2022
@Cal-L
Copy link
Contributor

Cal-L commented Feb 1, 2022

Let's resolve this warning:
Failed prop type: The prop ticker is marked as required in PaymentMethodSelectorView, but its value is undefined

@wachunei
Copy link
Member Author

wachunei commented Feb 1, 2022

@Cal-L fixed in 05eaf1d

@rickycodes rickycodes self-requested a review February 4, 2022 00:18
andrepimenta
andrepimenta approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 4, 2022
@andrepimenta andrepimenta added the Priority - High Task with high priority label Feb 4, 2022
@wachunei wachunei merged commit 8082e92 into main Feb 8, 2022
@wachunei wachunei deleted the feature/allow-stablecoins-on-ramp branch February 8, 2022 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2022
@wachunei wachunei removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Feb 8, 2022
@gantunesr gantunesr added the Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking label Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

@rickycodes rickycodes Awaiting requested review from rickycodes

Assignees
No one assigned
Labels
Priority - High Task with high priority Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wachunei @Cal-L @rickycodes @andrepimenta @gantunesr