Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert svg crash fix #3690

Merged
merged 5 commits into from
Feb 14, 2022
Merged

Revert svg crash fix #3690

merged 5 commits into from
Feb 14, 2022

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Feb 3, 2022

Description

This PR reverts a temporal fix to avoid SVG crashes regarding the UNI V3 NFT.

To test this development, it's necessary to have an UNI V3 NFT. The app shouldn't crash after the user adds this NFT.

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking Code Impact - Low Minor code change that can safely applied to the codebase labels Feb 3, 2022
@gantunesr gantunesr requested a review from a team February 3, 2022 20:26
@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 14, 2022
@gantunesr gantunesr merged commit bcc22b3 into main Feb 14, 2022
@gantunesr gantunesr deleted the revert/fix/uni-v3-nft-crash branch February 14, 2022 22:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Code Impact - Low Minor code change that can safely applied to the codebase Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants