Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add credit card support and change copy #3703

Merged
merged 22 commits into from
Mar 15, 2022
Merged

Add credit card support and change copy #3703

merged 22 commits into from
Mar 15, 2022

Conversation

Fatxx
Copy link
Contributor

@Fatxx Fatxx commented Feb 7, 2022 •
edited

Description

Add credit card option to Apple Pay and change copy to enforce support of only Visa and Mastercard card types.

For QA to check both Credit and Debit cards.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3522

@Fatxx Fatxx requested a review from a team as a code owner February 7, 2022 19:55
@Fatxx Fatxx added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Feb 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Fatxx Fatxx added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 7, 2022
@jsolderitsch jsolderitsch mentioned this pull request Feb 8, 2022
Closed
@blackdevelopa blackdevelopa removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 10, 2022
@gantunesr gantunesr added the Priority - High Task with high priority label Mar 2, 2022
gantunesr
gantunesr requested changes Mar 8, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert changes in

  • android/app/build.gradle
  • bitrise.yml
  • ios/MetaMask.xcodeproj/project.pbxproj
  • package.json

Before merging

@Fatxx Fatxx added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 10, 2022
gantunesr
gantunesr approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shall pass

@cortisiko cortisiko merged commit 7192253 into main Mar 15, 2022
@cortisiko cortisiko deleted the fix/apple-pay-credit-card-support branch March 15, 2022 19:07
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
Priority - High Task with high priority Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to buy Ether via Apple Pay
4 participants
@Fatxx @gantunesr @blackdevelopa @cortisiko