Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fixes deeplinks on Android 12 and other deeplinks minor fixes #3721

Merged
merged 7 commits into from
Feb 9, 2022
Merged

[FIX] Fixes deeplinks on Android 12 and other deeplinks minor fixes #3721

merged 7 commits into from
Feb 9, 2022

Conversation

andreahaku
Copy link
Member

@andreahaku andreahaku commented Feb 9, 2022 •
edited

Description
Fixes deeplinks on Android 12 and other deeplinks minor fixes like multiple tabs opening when tapping deep links from other apps and other minor issues with WalletConnect deep links.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3534
Resolves #3395
Resolves #3525

@andreahaku andreahaku changed the title Adds support deeplink on Android 12 and other deeplink minor fixes [FIX] Fixes deeplinks on Android 12 and other deeplinks minor fixes Feb 9, 2022
@andreahaku andreahaku self-assigned this Feb 9, 2022
@andreahaku andreahaku added Code Impact - Medium Average task code change that can relatively safely being applied to the codebase needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. Priority - High Task with high priority labels Feb 9, 2022
@andreahaku andreahaku requested a review from a team February 9, 2022 08:44
@andreahaku andreahaku marked this pull request as ready for review February 9, 2022 08:44
Cal-L
Cal-L approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreahaku andreahaku removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 9, 2022
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 9, 2022
cortisiko
cortisiko approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@andreahaku andreahaku merged commit e772051 into main Feb 9, 2022
@andreahaku andreahaku deleted the bugfix/android12_deeplink branch February 9, 2022 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr left review comments

@Cal-L Cal-L Cal-L approved these changes

@cortisiko cortisiko cortisiko approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees

@andreahaku andreahaku

Labels
Code Impact - Medium Average task code change that can relatively safely being applied to the codebase Priority - High Task with high priority QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
5 participants
@andreahaku @Cal-L @cortisiko @gantunesr @blackdevelopa