Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting of gas price for all conversion currencies #3731

Merged
merged 10 commits into from
Mar 25, 2022
Merged

Fix formatting of gas price for all conversion currencies #3731

merged 10 commits into from
Mar 25, 2022

Conversation

Fatxx
Copy link
Contributor

@Fatxx Fatxx commented Feb 10, 2022

Description

Fix formatting of gas price for all types of conversion currencies.
Removed unnecessary external library for currency formatting since it is now natively supported by ECMAScript Internationalization API.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3498

@Fatxx Fatxx requested a review from a team as a code owner February 10, 2022 17:16
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Fatxx Fatxx added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 10, 2022
andreahaku
andreahaku approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added QA in Progress QA has started on the feature. QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. labels Feb 15, 2022
cortisiko
cortisiko requested changes Feb 15, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Android specific] If i were to go:

change my fiat currency from USD to BNT
go to uniswap
attempt to swap, the app crashes: http://recordit.co/knzyiMM8nw

I see this in the logs:

 ERROR  ReferenceError: Can't find variable: Intl

This error is located at:
    in TransactionReviewInformation (created by Connect(TransactionReviewInformation))
    in Connect(TransactionReviewInformation) (at TransactionReview/index.js:376)
    in RCTView (at View.js:32)
    in View (at TransactionReview/index.js:372)
    in TouchableWithoutFeedback (at ActionView/index.js:54)
    in RCTView (at View.js:32)
    in View (at ScrollView.js:1674)
    in RCTScrollView (at ScrollView.js:1792)
    in ScrollView (at ScrollView.js:1818)
    in ScrollView (at KeyboardAwareHOC.js:537)
    in KeyboardAwareScrollView (at ActionView/index.js:49)
    in RCTView (at View.js:32)
    in View (at ActionView/index.js:48)
    in ActionView (at TransactionReview/index.js:364)
    in RCTView (at View.js:32)
    in View (at TransactionReview/index.js:363)
    in RCTView (at View.js:32)
    in View (at createAnimatedComponent.js:242)
    in AnimatedComponent (at createAnimatedComponent.js:295)
    in AnimatedComponentWrapper (at TransactionReview/index.js:353)
    in TransactionReview (created by Connect(TransactionReview))
    in Connect(TransactionReview) (at TransactionEditor/index.js:809)
    in RCTView (at View.js:32)
    in View (at createAnimatedComponent.js:242)
    in AnimatedComponent (at createAnimatedComponent.js:295)
    in AnimatedComponentWrapper (at AnimatedTransactionModal/index.js:225)
    in RCTView (at View.js:32)
    in View (at createAnimatedComponent.js:242)
    in AnimatedComponent (at createAnimatedComponent.js:295)
    in AnimatedComponentWrapper (at AnimatedTransactionModal/index.js:216)
    in AnimatedTransactionModal (at TransactionEditor/index.js:808)
    in RCTView (at View.js:32)
    in View (at ScrollView.js:1674)
    in RCTScrollView (at ScrollView.js:1792)
    in ScrollView (at ScrollView.js:1818)
    in ScrollView (at KeyboardAwareHOC.js:537)
    in KeyboardAwareScrollView (at TransactionEditor/index.js:807)
    in TransactionEditor (created by Connect(TransactionEditor))
    in Connect(TransactionEditor) (at Approval/index.js:361)
    in RCTView (at View.js:32)
    in View (at createAnimatedComponent.js:242)
    in AnimatedComponent (at createAnimatedComponent.js:295)
    in AnimatedComponentWrapper (at createAnimatableComponent.js:599)
    in withAnimatable(View) (created by ReactNativeModal)
    in RCTView (at View.js:32)
    in View (at AppContainer.js:92)
    in RCTView (at View.js:32)
    in View (at AppContainer.js:119)
    in AppContainer (at Modal.js:242)
    in RCTView (at View.js:32)
    in View (at Modal.js:270)
    in VirtualizedListContextResetter (at Modal.js:268)
    in RCTModalHostView (at Modal.js:248)
    in Modal (created by ReactNativeModal)
    in ReactNativeModal (at Approval/index.js:347)
    in Approval (created by Connect(Approval))
    in Connect(Approval) (at Main/index.js:547)
    in Main (created by Connect(Main))
    in Connect(Main) (at SceneView.tsx:122)
    in StaticContainer
    in EnsureSingleNavigator (at SceneView.tsx:114)
    in SceneView (at useDescriptors.tsx:153)
    in RCTView (at View.js:32)
    in View (at CardContainer.tsx:245)
    in RCTView (at View.js:32)
    in View (at CardContainer.tsx:244)
    in RCTView (at View.js:32)
    in View (at CardSheet.tsx:33)
    in CardSheet (at Card.tsx:573)
    in RCTView (at View.js:32)
    in View (at createAnimatedComponent.js:242)
    in AnimatedComponent (at createAnimatedComponent.js:295)
    in AnimatedComponentWrapper (at Card.tsx:555)
    in PanGestureHandler (at GestureHandlerNative.tsx:13)
    in PanGestureHandler (at Card.tsx:549)
    in RCTView (at View.js:32)
    in View (at createAnimatedComponent.js:242)
    in AnimatedComponent (at createAnimatedComponent.js:295)
    in AnimatedComponentWrapper (at Card.tsx:544)
    in RCTView (at View.js:32)
    in View (at Card.tsx:538)
    in Card (at CardContainer.tsx:206)
    in CardContainer (at CardStack.tsx:623)
    in RNSScreen (at createAnimatedComponent.js:242)
    in AnimatedComponent (at createAnimatedComponent.js:295)
    in AnimatedComponentWrapper (at src/index.native.tsx:147)
    in Screen (at Screens.tsx:74)
    in MaybeScreen (at CardStack.tsx:616)
    in RNSScreenContainer (at src/index.native.tsx:186)
    in ScreenContainer (at Screens.tsx:50)
    in MaybeScreenContainer (at CardStack.tsx:498)
    in CardStack (at StackView.tsx:462)
    in KeyboardManager (at StackView.tsx:458)
    in SafeAreaProviderCompat (at StackView.tsx:455)
    in RCTView (at View.js:32)
    in View (at GestureHandlerRootView.android.tsx:21)
    in GestureHandlerRootView (at StackView.tsx:454)
    in StackView (at createStackNavigator.tsx:87)
    in StackNavigator (at Main/index.js:809)
    in MainFlow (at SceneView.tsx:122)
    in StaticContainer
    in EnsureSingleNavigator (at SceneView.tsx:114)
    in SceneView (at useDescriptors.tsx:153)
    in RCTView (at View.js:32)
    in View (at CardContainer.tsx:245)
    in RCTView (at View.js:32)
    in View (at CardContainer.tsx:244)
    in RCTView (at View.js:32)
    in View (at CardSheet.tsx:33)
    in CardSheet (at Card.tsx:573)
    in RCTView (at View.js:32)
    in View (at createAnimatedComponent.js:242)
    in AnimatedComponent (at createAnimatedComponent.js:295)
    in AnimatedComponentWrapper (at Card.tsx:555)
    in PanGestureHandler (at GestureHandlerNative.tsx:13)
    in PanGestureHandler (at Card.tsx:549)
    in RCTView (at View.js:32)
    in View (at createAnimatedComponent.js:242)
    in AnimatedComponent (at createAnimatedComponent.js:295)
    in AnimatedComponentWrapper (at Card.tsx:544)
    in RCTView (at View.js:32)
    in View (at Card.tsx:538)
    in Card (at CardContainer.tsx:206)
    in CardContainer (at CardStack.tsx:623)
    in RNSScreen (at createAnimatedComponent.js:242)
    in AnimatedComponent (at createAnimatedComponent.js:295)
    in AnimatedComponentWrapper (at src/index.native.tsx:147)
    in Screen (at Screens.tsx:74)
    in MaybeScreen (at CardStack.tsx:616)
    in RNSScreenContainer (at src/index.native.tsx:186)
    in ScreenContainer (at Screens.tsx:50)
    in MaybeScreenContainer (at CardStack.tsx:498)
    in CardStack (at StackView.tsx:462)
    in KeyboardManager (at StackView.tsx:458)
    in RNCSafeAreaProvider (at SafeAreaContext.tsx:76)
    in SafeAreaProvider (at SafeAreaProviderCompat.tsx:42)
    in SafeAreaProviderCompat (at StackView.tsx:455)
    in GestureHandlerRootView (at GestureHandlerRootView.android.tsx:26)
    in GestureHandlerRootView (at StackView.tsx:454)
    in StackView (at createStackNavigator.tsx:87)
    in StackNavigator (at App/index.js:277)
    in EnsureSingleNavigator (at BaseNavigationContainer.tsx:409)
    in BaseNavigationContainer (at NavigationContainer.tsx:91)
    in ThemeProvider (at NavigationContainer.tsx:90)
    in NavigationContainer (at App/index.js:266)
    in RCTView (at View.js:32)
    in View (at App/index.js:265)
    in App (created by Connect(App))
    in Connect(App) (at Root/index.js:44)
    in ErrorBoundary (at Root/index.js:43)
    in PersistGate (at Root/index.js:42)
    in Provider (at Root/index.js:41)
    in Root (at renderApplication.js:50)
    in RCTView (at View.js:32)
    in View (at AppContainer.js:92)
    in RCTView (at View.js:32)
    in View (at AppContainer.js:119)
    in AppContainer (at renderApplication.js:43)
    in MetaMask(RootComponent) (at renderApplication.js:60)

@Fatxx
Copy link
Contributor Author

Fatxx commented Feb 21, 2022

@cortisiko just fixed you can QA again if you like

@Fatxx Fatxx added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Feb 21, 2022
@gantunesr gantunesr added Priority - Medium Task with medium priority and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 2, 2022
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 23, 2022
cortisiko
cortisiko approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@cortisiko cortisiko merged commit f1bee2a into main Mar 25, 2022
@cortisiko cortisiko deleted the fix/conversion-currency-not-showing-proper-value branch March 25, 2022 17:06
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
Priority - Medium Task with medium priority QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some tokens when set as the "Conversion currency" not showing proper value
4 participants
@Fatxx @andreahaku @cortisiko @gantunesr