Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Release - Error message for missing chain ID in deeplink #3738

Merged
merged 2 commits into from
Feb 14, 2022
Merged

[FIX] Release - Error message for missing chain ID in deeplink #3738

merged 2 commits into from
Feb 14, 2022

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Feb 14, 2022 •
edited

Description

Update error message when deeplink doesn't include a chain ID.

Before: Network with chain id {{chain_id}} not found in your wallet. Please add the network first.
After: Missing chain id.

This fix requires a review from a designer .

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

No issue related

@gantunesr gantunesr added design-review Any feature that needs feedback from the design team needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 14, 2022
@gantunesr gantunesr requested a review from a team as a code owner February 14, 2022 01:36
andreahaku
andreahaku approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr merged commit 2a41929 into release/v4.1.0-RC1 Feb 14, 2022
@gantunesr gantunesr deleted the fix/release/deeplink-error-msg branch February 14, 2022 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees
No one assigned
Labels
design-review Any feature that needs feedback from the design team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gantunesr @andreahaku