Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance auto-detection warning #3762

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Enhance auto-detection warning #3762

merged 3 commits into from
Feb 16, 2022

Conversation

danfinlay
Copy link
Contributor

Fixes #3761

Open to other wordings too, what do you think?

@danfinlay
Enhance auto-detection warning
d8b7c45 
Fixes #3761

Open to other wordings too, what do you think?
@danfinlay danfinlay requested a review from a team as a code owner February 15, 2022 23:51
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman
Copy link
Contributor

@danfinlay I like this wording update. We need to apply it to the extension. I will open a PR.

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Feb 16, 2022
Cal-L
Cal-L approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman mentioned this pull request Feb 16, 2022
Closed
@sethkfman
Copy link
Contributor

Updated copy on extension: MetaMask/metamask-extension#13655
@danfinlay

@danfinlay danfinlay merged commit 929e6b3 into main Feb 16, 2022
@danfinlay danfinlay deleted the auto-detect-nft-copy-change branch February 16, 2022 23:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance OpenSea enable copy
4 participants
@danfinlay @sethkfman @Cal-L @gantunesr