Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Default spent limit value #3787

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Conversation

gantunesr
Copy link
Member

Description
Papercuts - During a transaction review, the user is able to select a "Custom spent limit" for a token. If the user select the custom limit without changing the value (i.e. use the default custom value), the app should show the default value as the limit.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3786

@gantunesr gantunesr added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking labels Feb 21, 2022
@gantunesr gantunesr requested a review from a team as a code owner February 21, 2022 01:59
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 22, 2022
@gantunesr gantunesr merged commit 17061ae into main Feb 22, 2022
@gantunesr gantunesr deleted the fix/papercuts/approval-default-value branch February 22, 2022 21:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default value in spent limit doesn't update the transaction
2 participants