Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem when loading unknown icons on Swap token list #3811

Merged
merged 12 commits into from
Feb 24, 2022
Merged

Fix problem when loading unknown icons on Swap token list #3811

merged 12 commits into from
Feb 24, 2022

Conversation

Fatxx
Copy link
Contributor

@Fatxx Fatxx commented Feb 24, 2022 •
edited

Description

There was an exception when an URL for an icon returned 404, this PR patches react-native-svg in order to improve error handling and also adds proper component fallback for not found asset icons.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3760

@Fatxx Fatxx requested a review from a team as a code owner February 24, 2022 00:52
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Fatxx Fatxx added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 24, 2022
@cortisiko cortisiko added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 24, 2022
cortisiko
cortisiko approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@gantunesr gantunesr merged commit ce6f257 into main Feb 24, 2022
@gantunesr gantunesr deleted the fix/swap-flow-null-is-not-an-object branch February 24, 2022 21:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

null is not an object (evaluating 'f.push')
3 participants
@Fatxx @cortisiko @gantunesr