Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MoonPay on-ramp support. Add CUSD and CEUR support for Transak #3846

Merged
merged 32 commits into from
Mar 25, 2022
Merged

Add MoonPay on-ramp support. Add CUSD and CEUR support for Transak #3846

merged 32 commits into from
Mar 25, 2022

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Mar 3, 2022 •
edited

This PR adds MoonPay support

⚠️ Keys
This PR needs a pair of keys added to .js.env, please ping me for values.

export MOONPAY_API_KEY_STAGING= // <sandbox key>
export MOONPAY_API_KEY_PRODUCTION= // <prod key>

@andrepimenta andrepimenta marked this pull request as ready for review March 11, 2022 17:41
@andrepimenta andrepimenta requested a review from a team as a code owner March 11, 2022 17:41
@andrepimenta andrepimenta added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Priority - High Task with high priority labels Mar 11, 2022
@andrepimenta andrepimenta mentioned this pull request Mar 11, 2022
Closed
@wachunei wachunei changed the title [WIP] MoonPay support MoonPay support Mar 11, 2022
@wachunei wachunei changed the title MoonPay support Add MoonPay on-ramp support Mar 14, 2022
@wachunei wachunei changed the title Add MoonPay on-ramp support Add MoonPay on-ramp support. Add CUSD and CEUR support for Transak Mar 15, 2022
gantunesr
gantunesr reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wachunei do you have capacity to refactor the new components from JS to TS?

@wachunei
Copy link
Member Author

@wachunei do you have capacity to refactor the new components from JS to TS?

No new components are introduced, all are refactors from current ones. Which ones do you mean?

@gantunesr
Copy link
Member

No new components are introduced, all are refactors from current ones. Which ones do you mean?

Okay, I didn't realized that those were refactor components, I thought MoonPayWebView and MoonPayPaymentMethod were a new one.

Is orderProcessor/moonpay.js also a refactor or a new file?

@wachunei
Copy link
Member Author

MoonPayWebView and MoonPayPaymentMethod are new files but based on the same existing components. The orderProcessor/moonpay.js file is new but very similar to previous providers processor files.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Fatxx
Fatxx approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 22, 2022
@wachunei wachunei merged commit bd11758 into main Mar 25, 2022
@wachunei wachunei deleted the feature/onramp-moonpay branch March 25, 2022 15:25
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr left review comments

@Fatxx Fatxx Fatxx approved these changes

Assignees
No one assigned
Labels
Priority - High Task with high priority Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wachunei @gantunesr @Fatxx @andrepimenta @Cal-L