Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 'io.branch.referral.installListener' crashes on Android #3850

Merged
merged 6 commits into from
Mar 15, 2022
Merged

[FIX] 'io.branch.referral.installListener' crashes on Android #3850

merged 6 commits into from
Mar 15, 2022

Conversation

andreahaku
Copy link
Member

@andreahaku andreahaku commented Mar 4, 2022 •
edited

Description

Should fix 'io.branch.referral.installListener' crashes on Android reported on Sentry

https://android-developers.googleblog.com/2019/11/still-using-installbroadcast-switch-to.html
BranchMetrics/android-branch-deep-linking-attribution#804
BranchMetrics/android-branch-deep-linking-attribution#778

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

https://sentry.io/organizations/metamask/issues/?project=2299799&query=io.branch.referral.InstallListener&sort=freq&statsPeriod=30d

@gantunesr
Copy link
Member

@andreahaku what is missing in this development? It would be great to ship this in 4.3.0 to see if it reduces the Android crashes

@andrepimenta andrepimenta added next release Priority - High Task with high priority labels Mar 11, 2022
@andreahaku andreahaku marked this pull request as ready for review March 14, 2022 09:37
@andreahaku andreahaku requested a review from a team as a code owner March 14, 2022 09:37
@andreahaku andreahaku added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 14, 2022
@andreahaku
Copy link
Member Author

@andreahaku what is missing in this development? It would be great to ship this in 4.3.0 to see if it reduces the Android crashes

@gantunesr it should be ok ;)

gantunesr
gantunesr approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 14, 2022
@cortisiko cortisiko added QA in Progress QA has started on the feature. QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. QA in Progress QA has started on the feature. labels Mar 15, 2022
cortisiko
cortisiko approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮 🌮

@cortisiko cortisiko merged commit 7c7e01e into main Mar 15, 2022
@cortisiko cortisiko deleted the fix/branchio_referral_crashes branch March 15, 2022 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@gantunesr gantunesr gantunesr approved these changes

Assignees
No one assigned
Labels
next release Priority - High Task with high priority QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andreahaku @gantunesr @cortisiko @andrepimenta