Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Issue #172 #3863

Merged
merged 8 commits into from
Mar 9, 2022
Merged

[FIX] Issue #172 #3863

merged 8 commits into from
Mar 9, 2022

Conversation

gantunesr
Copy link
Member

No description provided.

@gantunesr gantunesr requested a review from a team as a code owner March 8, 2022 04:05
@gantunesr gantunesr added Priority - High Task with high priority needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 8, 2022
sethkfman
sethkfman approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 8, 2022
@plasmacorral plasmacorral added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 9, 2022
plasmacorral
plasmacorral approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@plasmacorral plasmacorral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve merging this for RC.

@gantunesr gantunesr merged commit 2fc4a3d into main Mar 9, 2022
@gantunesr gantunesr deleted the fix/limit-setting branch March 9, 2022 19:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@plasmacorral plasmacorral plasmacorral approved these changes

Assignees

@plasmacorral plasmacorral

Labels
Priority - High Task with high priority QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gantunesr @sethkfman @plasmacorral @cortisiko