Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSS attribution #3877

Merged
merged 15 commits into from
Mar 25, 2022
Merged

Add OSS attribution #3877

merged 15 commits into from
Mar 25, 2022

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented Mar 10, 2022

Description

This is an example of what keeping an automated up-to-date list of attributions in source could look like.

This adds oss-attribution-generator which can be run to generate a simple attributions.txt file. it also adds aforementioned generated file to source and introduces a ci job that will fail if the attributions aren't up-to-date (a dependency has been added or removed).

Finally, the app has been updated to point to this new file instead of linking to the outdated one on the website:

image

weee.mp4

@rickycodes rickycodes requested a review from a team as a code owner March 10, 2022 03:37
@rickycodes rickycodes changed the title Feature/add oss attribution Add OSS attribution Mar 10, 2022
@rickycodes
Copy link
Member Author

rickycodes commented Mar 10, 2022

this was minimal amount of effort, but I think it's a good start. maybe we should not keep the json file? we could also just put the attributions at the root so it's easier to find instead of this default folder?

@andrepimenta andrepimenta added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 11, 2022
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickycodes rickycodes merged commit 6b74684 into main Mar 25, 2022
@rickycodes rickycodes deleted the feature/add-oss-attribution branch March 25, 2022 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants