-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OSS attribution #3877
Merged
Merged
Add OSS attribution #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickycodes
commented
Mar 10, 2022
this was minimal amount of effort, but I think it's a good start. |
andrepimenta
added
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Mar 11, 2022
rickycodes
force-pushed
the
feature/add-oss-attribution
branch
from
March 11, 2022 19:16
cd479ad
to
70b0fe9
Compare
andreahaku
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rickycodes
force-pushed
the
feature/add-oss-attribution
branch
from
March 25, 2022 19:05
11bd81c
to
34a7255
Compare
wachunei
approved these changes
Mar 25, 2022
wachunei
approved these changes
Mar 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an example of what keeping an automated up-to-date list of attributions in source could look like.
This adds
oss-attribution-generator
which can be run to generate a simpleattributions.txt
file. it also adds aforementioned generated file to source and introduces a ci job that will fail if the attributions aren't up-to-date (a dependency has been added or removed).Finally, the app has been updated to point to this new file instead of linking to the outdated one on the website:
weee.mp4