Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Unsafe devices + other bugfixes #389

Merged
merged 7 commits into from
Feb 16, 2019
Merged

iOS Unsafe devices + other bugfixes #389

merged 7 commits into from
Feb 16, 2019

Conversation

brunobar79
Copy link
Contributor

@brunobar79 brunobar79 commented Feb 15, 2019

Description

  • Require password for iOS devices who don't have any lock method enabled (PIN / Biometrics)
  • Allow to remember the password in that scenario (off by default)
  • Fix Transaction submitted bugs
  • Added ropsten faucet to dapp-list
  • Added login button on onboarding screen for existing users

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #365

Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QAed on android, looking good!!

@brunobar79 brunobar79 merged commit 974b4da into develop Feb 16, 2019
@brunobar79 brunobar79 deleted the unsafe-devices branch February 18, 2019 18:51
@brunobar79 brunobar79 mentioned this pull request Feb 18, 2019
brunobar79 pushed a commit that referenced this pull request Feb 18, 2019
* URL Autocomplete (#378)

* initial work for autocomplete

* initial work for autocomplete

* autocomplete working

* Fix typo

* More missing locales (#381)

* add missing locales

* snapshot

* Support for develop branch (#377)

* Fade in images + bugfixes (#385)

* initial work for autocomplete

* initial work for autocomplete

* autocomplete working

* fade in images everywhere

* fade in images + fixes

* fix snapshots

* fix qr codes (#386)

* Collectible transaction details (#390)

* decode transfer data ERC721

* render tx element

* tx details refactor

* stable

* more refactor

* renderable gasprice

* render hash

* snapshots

* fadein

* Remove collectible if is being sent (#391)

* delete collectible if collectible is being sent

* remove collectible before clear tx

* if

* iOS Unsafe devices + other bugfixes (#389)

* add remember me for unprotected devices

* increase keychain security level

* fix snapshots

* fixes

* dont pop submit view when going to etherscan

* handle android back button

* Upgrade react native to v0.58.4 (#393)

* ios app working

* rn navigation & co updated

* fix snapshots

* remove extra files

* add mm faucet

* fix detox android

* Import from seed -  "remember me" option (#394)

* Added missing remember me in import from seed flow

* Update snapshot

* refactor complete (#395)

* Portrait orientation by default (#397)

* fix navbar when landscape

* fix portrait

* portrait android

* revert

* indentation

* Lock deps by commit sha1 (#400)

* lock deps by commit sha

* fix merge conflicts

* Show app version (#399)

* refactor complete

* show app version in settings => info

* fix bad indentation

* bump gaba (#401)
brunobar79 pushed a commit that referenced this pull request Feb 19, 2019
* Release 0.1.4 (#402)

* URL Autocomplete (#378)

* initial work for autocomplete

* initial work for autocomplete

* autocomplete working

* Fix typo

* More missing locales (#381)

* add missing locales

* snapshot

* Support for develop branch (#377)

* Fade in images + bugfixes (#385)

* initial work for autocomplete

* initial work for autocomplete

* autocomplete working

* fade in images everywhere

* fade in images + fixes

* fix snapshots

* fix qr codes (#386)

* Collectible transaction details (#390)

* decode transfer data ERC721

* render tx element

* tx details refactor

* stable

* more refactor

* renderable gasprice

* render hash

* snapshots

* fadein

* Remove collectible if is being sent (#391)

* delete collectible if collectible is being sent

* remove collectible before clear tx

* if

* iOS Unsafe devices + other bugfixes (#389)

* add remember me for unprotected devices

* increase keychain security level

* fix snapshots

* fixes

* dont pop submit view when going to etherscan

* handle android back button

* Upgrade react native to v0.58.4 (#393)

* ios app working

* rn navigation & co updated

* fix snapshots

* remove extra files

* add mm faucet

* fix detox android

* Import from seed -  "remember me" option (#394)

* Added missing remember me in import from seed flow

* Update snapshot

* refactor complete (#395)

* Portrait orientation by default (#397)

* fix navbar when landscape

* fix portrait

* portrait android

* revert

* indentation

* Lock deps by commit sha1 (#400)

* lock deps by commit sha

* fix merge conflicts

* Show app version (#399)

* refactor complete

* show app version in settings => info

* fix bad indentation

* bump gaba (#401)

* Update README.md (#327)

* Update README.md

* Updated instructions

* Update README.md

* fix indentation

* remove tabs

* Revert "Update README.md (#327)" (#406)

This reverts commit 403e63c.

* Revert "Revert "Update README.md (#327)" (#406)"

This reverts commit ebd8a4f.
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* add remember me for unprotected devices

* increase keychain security level

* fix snapshots

* fixes

* dont pop submit view when going to etherscan

* handle android back button
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* Release 0.1.4 (#402)

* URL Autocomplete (#378)

* initial work for autocomplete

* initial work for autocomplete

* autocomplete working

* Fix typo

* More missing locales (#381)

* add missing locales

* snapshot

* Support for develop branch (#377)

* Fade in images + bugfixes (#385)

* initial work for autocomplete

* initial work for autocomplete

* autocomplete working

* fade in images everywhere

* fade in images + fixes

* fix snapshots

* fix qr codes (#386)

* Collectible transaction details (#390)

* decode transfer data ERC721

* render tx element

* tx details refactor

* stable

* more refactor

* renderable gasprice

* render hash

* snapshots

* fadein

* Remove collectible if is being sent (#391)

* delete collectible if collectible is being sent

* remove collectible before clear tx

* if

* iOS Unsafe devices + other bugfixes (#389)

* add remember me for unprotected devices

* increase keychain security level

* fix snapshots

* fixes

* dont pop submit view when going to etherscan

* handle android back button

* Upgrade react native to v0.58.4 (#393)

* ios app working

* rn navigation & co updated

* fix snapshots

* remove extra files

* add mm faucet

* fix detox android

* Import from seed -  "remember me" option (#394)

* Added missing remember me in import from seed flow

* Update snapshot

* refactor complete (#395)

* Portrait orientation by default (#397)

* fix navbar when landscape

* fix portrait

* portrait android

* revert

* indentation

* Lock deps by commit sha1 (#400)

* lock deps by commit sha

* fix merge conflicts

* Show app version (#399)

* refactor complete

* show app version in settings => info

* fix bad indentation

* bump gaba (#401)

* Update README.md (#327)

* Update README.md

* Updated instructions

* Update README.md

* fix indentation

* remove tabs

* Revert "Update README.md (#327)" (#406)

This reverts commit 403e63c.

* Revert "Revert "Update README.md (#327)" (#406)"

This reverts commit ebd8a4f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants