Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude deps in build.gradle #3898

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Exclude deps in build.gradle #3898

merged 2 commits into from
Mar 16, 2022

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Mar 16, 2022

Description

#3897

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 16, 2022
@Cal-L Cal-L requested a review from a team as a code owner March 16, 2022 10:49
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

blackdevelopa
blackdevelopa reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@blackdevelopa blackdevelopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andreahaku
andreahaku approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it fixes for me as well.
LGTM!

@cortisiko cortisiko merged commit 50f5f97 into main Mar 16, 2022
@cortisiko cortisiko deleted the bug/3897-fix-android-build branch March 16, 2022 15:25
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2022
@mobularay mobularay added QA Passed A successful QA run through has been done and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wachunei wachunei wachunei approved these changes

@jpcloureiro jpcloureiro jpcloureiro approved these changes

@andreahaku andreahaku andreahaku approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Cal-L @wachunei @jpcloureiro @andreahaku @blackdevelopa @cortisiko @mobularay